Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version parsing v2 #1026

Merged
merged 1 commit into from
Oct 2, 2018
Merged

Conversation

r2d4
Copy link
Contributor

@r2d4 r2d4 commented Sep 25, 2018

just to test out https://github.com/GoogleContainerTools/skaffold/pull/1020/files#r220053214

  1. about 50% less code
  2. more functionality (from blang/semver)
  3. 100% test coverage apiversion.go + relying on a tested version library (blang/semver) vs. a custom one

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@codecov-io
Copy link

codecov-io commented Sep 25, 2018

Codecov Report

Merging #1026 into master will increase coverage by 0.31%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1026      +/-   ##
==========================================
+ Coverage   40.86%   41.17%   +0.31%     
==========================================
  Files          70       72       +2     
  Lines        3091     3121      +30     
==========================================
+ Hits         1263     1285      +22     
- Misses       1703     1707       +4     
- Partials      125      129       +4
Impacted Files Coverage Δ
pkg/skaffold/config/config.go 0% <ø> (ø) ⬆️
pkg/skaffold/apiversion/apiversion.go 100% <100%> (ø)
cmd/skaffold/app/cmd/util/util.go 55.55% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ec4835...84f3953. Read the comment docs.

@r2d4 r2d4 force-pushed the version-parsing-v2 branch from fab49be to 4c65a7f Compare September 25, 2018 17:51
@dgageot
Copy link
Contributor

dgageot commented Sep 29, 2018

@r2d4 this needs to be rebased

@r2d4 r2d4 force-pushed the version-parsing-v2 branch from 4c65a7f to 4f423d3 Compare September 30, 2018 16:09
@googlebot
Copy link

CLAs look good, thanks!

@r2d4
Copy link
Contributor Author

r2d4 commented Sep 30, 2018

done 👍

Print out help messages for configs too new or too old for the current
version of skaffold.
@r2d4 r2d4 force-pushed the version-parsing-v2 branch from 4f423d3 to 84f3953 Compare September 30, 2018 16:11
@dgageot dgageot merged commit 296d8ab into GoogleContainerTools:master Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants