-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version parsing v2 #1026
Version parsing v2 #1026
Conversation
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
Codecov Report
@@ Coverage Diff @@
## master #1026 +/- ##
==========================================
+ Coverage 40.86% 41.17% +0.31%
==========================================
Files 70 72 +2
Lines 3091 3121 +30
==========================================
+ Hits 1263 1285 +22
- Misses 1703 1707 +4
- Partials 125 129 +4
Continue to review full report at Codecov.
|
fab49be
to
4c65a7f
Compare
@r2d4 this needs to be rebased |
4c65a7f
to
4f423d3
Compare
CLAs look good, thanks! |
done 👍 |
Print out help messages for configs too new or too old for the current version of skaffold.
4f423d3
to
84f3953
Compare
just to test out https://github.com/GoogleContainerTools/skaffold/pull/1020/files#r220053214