Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce v1alpha4 config version #1062

Merged
merged 1 commit into from
Sep 29, 2018

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Sep 28, 2018

Signed-off-by: David Gageot david@gageot.net

@codecov-io
Copy link

codecov-io commented Sep 28, 2018

Codecov Report

Merging #1062 into master will increase coverage by 0.05%.
The diff coverage is 55.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1062      +/-   ##
==========================================
+ Coverage    40.8%   40.86%   +0.05%     
==========================================
  Files          70       70              
  Lines        3088     3091       +3     
==========================================
+ Hits         1260     1263       +3     
  Misses       1703     1703              
  Partials      125      125
Impacted Files Coverage Δ
pkg/skaffold/deploy/kubectl/cli.go 0% <ø> (ø) ⬆️
pkg/skaffold/build/gcb/cloud_build.go 0% <0%> (ø) ⬆️
pkg/skaffold/build/local/bazel.go 0% <0%> (ø) ⬆️
pkg/skaffold/deploy/kustomize.go 36.23% <0%> (ø) ⬆️
pkg/skaffold/config/config.go 0% <0%> (ø) ⬆️
cmd/skaffold/app/cmd/init.go 0% <0%> (ø) ⬆️
pkg/skaffold/build/local/types.go 0% <0%> (ø) ⬆️
pkg/skaffold/build/gcb/types.go 0% <0%> (ø) ⬆️
pkg/skaffold/runner/timings.go 15.15% <0%> (ø) ⬆️
pkg/skaffold/build/local/local.go 62.5% <100%> (ø) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 361e95c...2bc69a8. Read the comment docs.

@balopat
Copy link
Contributor

balopat commented Sep 28, 2018

@dgageot this looks great, thanks for introducing the latest aliases +100
kokoro failed with the upgrade test, otherwise LGTM:

  --- FAIL: TestFix/test_v1alpha3_to_v1alpha4_fix (0.09s)
    	run_test.go:265: testing error: exit status 1

Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after the kokoro fix

Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot merged commit 3ec4835 into GoogleContainerTools:master Sep 29, 2018
@dgageot dgageot deleted the v1alpha4 branch December 28, 2018 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants