Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve errors #1255

Merged
merged 2 commits into from
Nov 8, 2018
Merged

Improve errors #1255

merged 2 commits into from
Nov 8, 2018

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Nov 8, 2018

No description provided.

Should start with a lowercase

Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot mentioned this pull request Nov 8, 2018
@codecov-io
Copy link

Codecov Report

Merging #1255 into master will not change coverage.
The diff coverage is 42.1%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1255   +/-   ##
=======================================
  Coverage   42.24%   42.24%           
=======================================
  Files          96       96           
  Lines        4242     4242           
=======================================
  Hits         1792     1792           
  Misses       2276     2276           
  Partials      174      174
Impacted Files Coverage Δ
pkg/skaffold/build/tag/custom.go 30% <0%> (ø) ⬆️
pkg/skaffold/kubernetes/client.go 0% <0%> (ø) ⬆️
pkg/skaffold/deploy/labels.go 0% <0%> (ø) ⬆️
pkg/skaffold/kubernetes/port_forward.go 40.22% <0%> (ø) ⬆️
pkg/skaffold/util/util.go 52.13% <100%> (ø) ⬆️
pkg/skaffold/build/tag/sha256.go 72.72% <100%> (ø) ⬆️
pkg/skaffold/docker/client.go 58.13% <40%> (ø) ⬆️
pkg/skaffold/runner/runner.go 49.39% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1648a8...5f9be2d. Read the comment docs.

@dgageot dgageot merged commit a70f7b7 into GoogleContainerTools:master Nov 8, 2018
@dgageot dgageot deleted the improve-errors branch December 28, 2018 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants