Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract push/no-push logic into builder #1366

Merged
merged 1 commit into from
Dec 7, 2018

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Dec 6, 2018

Minor refactoring on Jib builders to make their code look more like the other's.
This is to prepare work on how builders tag images.

Signed-off-by: David Gageot david@gageot.net

Signed-off-by: David Gageot <david@gageot.net>
@codecov-io
Copy link

codecov-io commented Dec 6, 2018

Codecov Report

Merging #1366 into master will decrease coverage by 0.03%.
The diff coverage is 38.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1366      +/-   ##
==========================================
- Coverage   44.95%   44.91%   -0.04%     
==========================================
  Files         114      114              
  Lines        4921     4925       +4     
==========================================
  Hits         2212     2212              
- Misses       2482     2486       +4     
  Partials      227      227
Impacted Files Coverage Δ
pkg/skaffold/build/local/local.go 51.78% <0%> (+3.45%) ⬆️
pkg/skaffold/build/local/jib_gradle.go 21.87% <36.36%> (-3.13%) ⬇️
pkg/skaffold/build/local/jib_maven.go 38.59% <42.85%> (-2.92%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8faa62...55c353b. Read the comment docs.

@dgageot dgageot merged commit f54473e into GoogleContainerTools:master Dec 7, 2018
@dgageot dgageot deleted the minor-jib-refactoring branch December 28, 2018 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants