Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO-NOT-MERGE] Test kaniko improvements #1427

Closed

Conversation

balopat
Copy link
Contributor

@balopat balopat commented Dec 27, 2018

testing #1426 - it is not obvious for me why it's failing on kokoro.

Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@balopat balopat added !! do-not-merge !! kokoro:run runs the kokoro jobs on a PR labels Dec 27, 2018
Signed-off-by: David Gageot <david@gageot.net>
@balopat balopat force-pushed the test_kaniko_improvements branch from 19dd9ab to 96ff396 Compare December 27, 2018 02:42
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Dec 27, 2018
@codecov-io
Copy link

codecov-io commented Dec 27, 2018

Codecov Report

Merging #1427 into master will increase coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1427      +/-   ##
=========================================
+ Coverage   44.77%   44.8%   +0.02%     
=========================================
  Files         111     111              
  Lines        4554    4551       -3     
=========================================
  Hits         2039    2039              
+ Misses       2310    2307       -3     
  Partials      205     205
Impacted Files Coverage Δ
pkg/skaffold/build/kaniko/run.go 0% <0%> (ø) ⬆️
pkg/skaffold/build/kaniko/kaniko.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35995ab...96ff396. Read the comment docs.

@dgageot dgageot closed this Dec 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants