Add timeout flag for helm

[tjerkw]

No description provided.

[googlebot]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

[nkubala]

@tjerkw thanks for the contribution! This looks good, once you sign the CLA I'll be happy to merge it!

[tjerkw]

I signed it

[googlebot]

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

[priyawadhwa]

I checked manually and @tjerkw has signed the CLA, but @moustafab (who authored the first commit) still has to sign. @moustafab will you be able to sign it?

[priyawadhwa]

Thanks for contributing! Left one comment, which should address #1499 as well.

[priyawadhwa]

It may make more sense to have a Flags []string field, that way a change doesn't need to be made to skaffold every time a new flag needs to be added.

flags:
- --wait
- --timeout=50

and these can be directly appended to args in helm.go

[moustafab]

@priyawadhwa Please see #1507 I would rather just one of these has to be tracked... @tjerkw can you close this one?

[tjerkw]

I like the flags approach. It's more maintainable. We should do that instead of merging these pull requests. Do the other deploy commands (kubectl for example) also support flags in the skaffold file?

…

On Tue, Jan 29, 2019, 23:21 Moustafa Baiou ***@***.*** wrote: @priyawadhwa <https://github.com/priyawadhwa> Please see #1507 <#1507> I would rather just one of these has to be tracked... @tjerkw <https://github.com/tjerkw> can you close this one? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1506 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAx-sclTm8uERCptCPvhtkPFjhO7FIvAks5vIMl1gaJpZM4aMsZ5> .

[priyawadhwa]

Yup, it looks like this

[priyawadhwa]

Hey @tjerkw, if you plan on making this change, would it make sense to close #1507 and #1499 as duplicates?

[tjerkw]

Closed #1507 and #1499 since the flag based approach is a better way.

[tjerkw]

Closed in favor of #1673