Add logic for finding next available port for gRPC if provided one is in use #1742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkubala
requested review from
balopat,
dgageot,
priyawadhwa and
r2d4
as code owners
priyawadhwa
reviewed
Mar 6, 2019
|
|
||
| // getOpenPort tests the provided port for availability, | ||
| // and if it's already in use, finds another open port. | ||
| func getAvailablePort(port string) string { |
There was a problem hiding this comment.
You may be able to reuse some of the port-forwarding functions here --
getAvailablePort
portAvailable
There was a problem hiding this comment.
good call. I did some refactoring that will have a slight functional change on the way we select ports when forwarding, so gonna close this PR and open that one first, then reopen this on top of those changes.
Codecov Report
@@ Coverage Diff @@
## master #1742 +/- ##
==========================================
+ Coverage 47.02% 47.53% +0.51%
==========================================
Files 126 126
Lines 6180 6254 +74
==========================================
+ Hits 2906 2973 +67
- Misses 2981 2986 +5
- Partials 293 295 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1733
this adds a small function that makes skaffold a bit smarter about the port it uses for starting the gRPC event server. if the provided port is in use, it will attempt to parse out the port number and increment it until it finds a free port, or if the parsing fails, simply choose a random (valid) port and make sure it's free.
this will also issue a small warning to the user that their specified port is in use, if they provided a non-default port through the CLI.