Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bazel plugin & revert back to original #1989

Merged
merged 2 commits into from
Apr 20, 2019

Conversation

priyawadhwa
Copy link
Contributor

For reference, initial PRs that added this change were #1707 and #1662

@codecov-io
Copy link

Codecov Report

Merging #1989 into master will increase coverage by 0.73%.
The diff coverage is 28.98%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1989      +/-   ##
==========================================
+ Coverage   53.11%   53.84%   +0.73%     
==========================================
  Files         183      180       -3     
  Lines        7953     7832     -121     
==========================================
- Hits         4224     4217       -7     
+ Misses       3328     3218     -110     
+ Partials      401      397       -4
Impacted Files Coverage Δ
pkg/skaffold/build/local/local.go 39.68% <ø> (ø) ⬆️
pkg/skaffold/build/bazel/dependencies.go 93.33% <ø> (ø)
pkg/skaffold/build/plugin/core.go 33.33% <ø> (ø) ⬆️
pkg/skaffold/build/local/bazel.go 28.98% <28.98%> (+28.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f1297f...5bc349b. Read the comment docs.

@dgageot dgageot merged commit 5bc349b into GoogleContainerTools:master Apr 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants