Allow --no-cache to be passed to docker #2054

robertrbruno · 2019-05-01T21:52:00Z

As reference in: #2053

This is my first pull request so please carefully review. Happy to make fixes if I did something wrong.

Added NoCache to docker struct

Allow passing in of --no-cache flag

googlebot · 2019-05-01T21:52:08Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

tejal29

This is a great start.
Thank you.
Can you add tests for the same here pkg/skaffold/docker/image_test.go#L178

priyawadhwa

Left a few comments, thanks for contributing!

pkg/skaffold/schema/latest/config.go

pkg/skaffold/docker/image.go

priyawadhwa · 2019-05-01T22:03:31Z

pkg/skaffold/schema/latest/config.go

@@ -631,6 +631,9 @@ type DockerArtifact struct {
 	// CacheFrom lists the Docker images used as cache sources.
 	// For example: `["golang:1.10.1-alpine3.7", "alpine:3.7"]`.
 	CacheFrom []string `yaml:"cacheFrom,omitempty"`
+
+	// pass in --no-cache to docker build to prevent caching


I think this comment needs to be in the form

NoCache blah blah blah. otherwise the tests will complain 😅

add no-cache test

Make bool and improve doc string

Change for bool

priyawadhwa

one more comment!

pkg/skaffold/docker/image_test.go

changed test for no-cache to be bool value

Fixed documentation

tejal29 · 2019-05-01T23:26:59Z

Looks like 2 of the tests are failing.

continuous-integration/appveyor/pr
If you look at the logs, by clicking on the Details, you see the test error.

?   	github.com/GoogleContainerTools/skaffold/examples/tagging-with-environment-variables	[no test files]
?   	github.com/GoogleContainerTools/skaffold/hack/new_config_version	[no test files]
?   	github.com/GoogleContainerTools/skaffold/hack/release_notes	[no test files]
--- FAIL: TestSchemas (0.20s)
    main_test.go:37: json schema files are not up to date. Please run `make generate-schemas` and commit the changes.
FAIL
FAIL	github.com/GoogleContainerTools/skaffold/hack/schemas	0.295s
ok  	github.com/GoogleContainerTools/skaffold/integration	0.200s
?   	github.com/GoogleContainerTools/skaffold/integration/examples/bazel	[no test files]
?   	github.com/GoogleContainerTools/skaffold/integration/examples/compose	[no test files]

Please run make generate-schemas and then commit the results.
2. cla/google:
Please sign the google by following steps mentioned in #2054 (comment)

googlebot · 2019-05-02T00:23:29Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

robertrbruno · 2019-05-02T00:45:00Z

The last commit was actually me but didn't have my username and email configured in git. Is there a way to fix the CLA issue easily? Sorry for all of the issues.

googlebot · 2019-05-02T01:09:50Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

robertrbruno · 2019-05-02T01:10:55Z

Learned way too much about git today lol. Removed the commit with bad author.

remove extra space

codecov-io · 2019-05-02T02:24:32Z

Codecov Report

Merging #2054 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2054      +/-   ##
==========================================
+ Coverage   56.04%   56.06%   +0.01%     
==========================================
  Files         179      179              
  Lines        7742     7745       +3     
==========================================
+ Hits         4339     4342       +3     
  Misses       2987     2987              
  Partials      416      416

Impacted Files	Coverage Δ
pkg/skaffold/schema/latest/config.go	`100% <ø> (ø)`	⬆️
pkg/skaffold/docker/image.go	`71.92% <100%> (+0.5%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15868fb...f3fae40. Read the comment docs.

priyawadhwa

LGTM, thanks for the contribution!

robertrbruno · 2019-05-02T18:24:30Z

Thanks for the opportunity and all the help. Learned a lot!

amendoza-navent · 2021-03-05T04:51:00Z

Hi, sorry but I have a question related to this topic, Does this option set the env var DOCKER_BUILDKIT=1 when docker build is executed? Or is there another way to do with skaffold.yaml? thanks!

nkubala · 2021-03-17T20:29:31Z

@amendoza-navent in your skaffold.yaml:

build:
  local:
    useBuildKit: true

robertrbruno added 2 commits May 1, 2019 17:41

Update config.go

6162e72

Added NoCache to docker struct

Update image.go

bece804

Allow passing in of --no-cache flag

robertrbruno requested review from balopat, dgageot, nkubala, priyawadhwa and tejal29 as code owners May 1, 2019 21:52

googlebot added the cla: no label May 1, 2019

tejal29 reviewed May 1, 2019

View reviewed changes

priyawadhwa reviewed May 1, 2019

View reviewed changes

robertrbruno added 3 commits May 1, 2019 18:06

Update image_test.go

ca17237

add no-cache test

Update config.go

b50ca74

Make bool and improve doc string

Update image.go

06947a8

Change for bool

priyawadhwa reviewed May 1, 2019

View reviewed changes

pkg/skaffold/docker/image_test.go Outdated Show resolved Hide resolved

robertrbruno added 2 commits May 1, 2019 18:58

Update image_test.go

185aa55

changed test for no-cache to be bool value

Update config.go

86d0b02

Fixed documentation

ran generate-schemas with correct author again

9ca16e4

googlebot added cla: yes and removed cla: no labels May 2, 2019

robertrbruno and others added 2 commits May 1, 2019 21:41

Update image.go

05f5e20

remove extra space

fix whitespace issues

f3fae40

priyawadhwa added the kokoro:run runs the kokoro jobs on a PR label May 2, 2019

kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label May 2, 2019

priyawadhwa approved these changes May 2, 2019

View reviewed changes

priyawadhwa merged commit 339edec into GoogleContainerTools:master May 2, 2019

priyawadhwa mentioned this pull request May 2, 2019

Ability to disable all docker build caching #2053

Closed

alexkreidler mentioned this pull request Jul 26, 2020

Add a no-cache option to the command line to allow one-off full rebuilds #4571

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow --no-cache to be passed to docker #2054

Allow --no-cache to be passed to docker #2054

robertrbruno commented May 1, 2019

googlebot commented May 1, 2019

tejal29 left a comment

priyawadhwa left a comment

priyawadhwa May 1, 2019

robertrbruno May 1, 2019

priyawadhwa left a comment

tejal29 commented May 1, 2019

googlebot commented May 2, 2019

robertrbruno commented May 2, 2019

googlebot commented May 2, 2019

robertrbruno commented May 2, 2019

codecov-io commented May 2, 2019

priyawadhwa left a comment

robertrbruno commented May 2, 2019

amendoza-navent commented Mar 5, 2021

nkubala commented Mar 17, 2021

Allow --no-cache to be passed to docker #2054

Allow --no-cache to be passed to docker #2054

Conversation

robertrbruno commented May 1, 2019

googlebot commented May 1, 2019

What to do if you already signed the CLA

Individual signers

Corporate signers

tejal29 left a comment

Choose a reason for hiding this comment

priyawadhwa left a comment

Choose a reason for hiding this comment

priyawadhwa May 1, 2019

Choose a reason for hiding this comment

robertrbruno May 1, 2019

Choose a reason for hiding this comment

priyawadhwa left a comment

Choose a reason for hiding this comment

tejal29 commented May 1, 2019

googlebot commented May 2, 2019

robertrbruno commented May 2, 2019

googlebot commented May 2, 2019

robertrbruno commented May 2, 2019

codecov-io commented May 2, 2019

Codecov Report

priyawadhwa left a comment

Choose a reason for hiding this comment

robertrbruno commented May 2, 2019

amendoza-navent commented Mar 5, 2021

nkubala commented Mar 17, 2021