Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix kubectl apply error handling #2076

Merged
merged 1 commit into from
May 7, 2019
Merged

🐛 fix kubectl apply error handling #2076

merged 1 commit into from
May 7, 2019

Conversation

pyaillet
Copy link
Contributor

@pyaillet pyaillet commented May 6, 2019

Hi !

Thanks for skaffold it's a really nice project !

I gave a try at fixing #1738 😄

Thanks to @charlyx for his help 🤗

@tejal29 tejal29 added the kokoro:run runs the kokoro jobs on a PR label May 6, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label May 6, 2019
@nkubala nkubala merged commit d303b00 into GoogleContainerTools:master May 7, 2019
@nkubala nkubala mentioned this pull request May 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tejal29 tejal29 tejal29 approved these changes

@balopat balopat Awaiting requested review from balopat

@dgageot dgageot Awaiting requested review from dgageot

@nkubala nkubala Awaiting requested review from nkubala

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pyaillet @tejal29 @googlebot @nkubala @kokoro-team