Add ability to pass an explicit registry value to Helm charts #2188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelbeaumont
requested review from
balopat,
briandealwis,
chanseokoh,
dgageot,
loosebazooka,
nkubala,
priyawadhwa,
TadCordle and
tejal29
as code owners
Codecov Report
|
tejal29
reviewed
May 28, 2019
There was a problem hiding this comment.
In general this looks an ok change.
Few nits:
- Please add unit tests for expliciteRegistry config
- The way we do config changes is a little bit hairy.
- We first merge the PR where we freeze config.
- Then merge the PR with config change.
Can you revert the config freeze change from this PR?
Done, should I open a PR for the config? I left out the |
Closed
|
@dgageot Can we run kokora again? could the time out have something to do with cloudflare's issues yesterday? |
dgageot
added
kokoro:run
|
@michaelbeaumont kokoro can't simply be retriggered. The easiest way would be for you to rebase on top of master. |
balopat
approved these changes
Jul 9, 2019
balopat
previously requested changes
Jul 9, 2019
|
Pinging @balopat |
|
sorry @michaelbeaumont, looks like you need one more rebase. once you do that CI should be green and I think this is good to go |
|
@nkubala Done! |
|
@nkubala Can we please get this merged 🙏 |
nkubala
approved these changes
Jul 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've run into a problem deploying a chart based on stable/postgresql where an explicit
registryvalue is expected when the templates are rendered. I'm not sure how common this pattern is amongst other charts but given that Postgres uses it and it seems reasonable in general, it seemed ok to me to add it as an option to Skaffold.