Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test for one method in diagnose. #2238

Merged
merged 1 commit into from
Jun 8, 2019
Merged

add test for one method in diagnose. #2238

merged 1 commit into from
Jun 8, 2019

Conversation

tejal29
Copy link
Contributor

@tejal29 tejal29 commented Jun 7, 2019

Add test for one of the methods in diagnose.

@codecov-io
Copy link

Codecov Report

Merging #2238 into master will increase coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2238      +/-   ##
==========================================
+ Coverage   60.03%   60.14%   +0.11%     
==========================================
  Files         185      185              
  Lines        7794     7794              
==========================================
+ Hits         4679     4688       +9     
+ Misses       2728     2719       -9     
  Partials      387      387
Impacted Files Coverage Δ
pkg/skaffold/docker/parse.go 85.95% <100%> (ø) ⬆️
pkg/skaffold/runner/diagnose.go 13.04% <0%> (+13.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bca710f...a95342e. Read the comment docs.

@balopat balopat merged commit 5312280 into master Jun 8, 2019
@tejal29 tejal29 deleted the add_diagnose branch June 14, 2019 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants