Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add resources to Kaniko init container #2260

Merged
merged 3 commits into from
Jun 13, 2019
Merged

Add resources to Kaniko init container #2260

merged 3 commits into from
Jun 13, 2019

Conversation

cedrickring
Copy link
Contributor

Fixes #2159

I used fixed resource quotas for the init container as I don't think a while-loop needs configurable resources.

priyawadhwa
priyawadhwa reviewed Jun 12, 2019
View reviewed changes
Copy link
Contributor

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this issue! Left a suggestion.

pkg/skaffold/build/cluster/sources/localdir.go Outdated Show resolved Hide resolved
priyawadhwa
priyawadhwa reviewed Jun 13, 2019
View reviewed changes
Copy link
Contributor

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last comment, otherwise it's looking good!

pkg/skaffold/build/cluster/sources/localdir_test.go Outdated Show resolved Hide resolved
@priyawadhwa priyawadhwa added the kokoro:run runs the kokoro jobs on a PR label Jun 13, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Jun 13, 2019
priyawadhwa
priyawadhwa approved these changes Jun 13, 2019
View reviewed changes
Copy link
Contributor

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this!

@priyawadhwa priyawadhwa merged commit 05d3b2e into GoogleContainerTools:master Jun 13, 2019
@cedrickring cedrickring deleted the init-container-resources branch June 17, 2019 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priyawadhwa priyawadhwa priyawadhwa approved these changes

@balopat balopat Awaiting requested review from balopat

@dgageot dgageot Awaiting requested review from dgageot

@nkubala nkubala Awaiting requested review from nkubala

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error creating kaniko pod because of resource quotas
4 participants
@cedrickring @priyawadhwa @googlebot @kokoro-team