Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve skaffold help output #2324

Merged
merged 6 commits into from
Jul 9, 2019

Conversation

medyagh
Copy link
Member

@medyagh medyagh commented Jun 24, 2019

Matches kubectl help style, categorizes skaffold help output to categorize under:

  • Pipeline building blocks for CI/CD
  • Getting started with a new project
  • Utilities

Closes this #1580

@medyagh medyagh changed the title Add command categorization to skaffold help Add categorization to skaffold help Jun 24, 2019
@medyagh medyagh changed the title Add categorization to skaffold help Improve skaffold help output Jun 24, 2019
@priyawadhwa
Copy link
Contributor

Just some docs errors!

--- FAIL: TestPrintMan (0.06s)
    man_test.go:52: You have skaffold command changes but haven't generated the CLI reference docs. Please run ./hack/generate-man.sh and commit the results!

@medyagh medyagh added the docs-modifications runs the docs preview service on the given PR label Jun 26, 2019
@container-tools-bot
Copy link

Please visit http://35.235.114.123:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Jun 26, 2019
@dgageot
Copy link
Contributor

dgageot commented Jun 26, 2019

@medyagh there's a test (TestMainHelp) that verifies a few words in the skaffold help output.

@balopat
Copy link
Contributor

balopat commented Jun 27, 2019

hehe, we missed that (I was pairing on this with Medya), thanks for the pointer :)

@dgageot
Copy link
Contributor

dgageot commented Jul 2, 2019

ping @medyagh do you need any help to fix this PR?

@medyagh
Copy link
Member Author

medyagh commented Jul 8, 2019

sorry for the delay, I am on it now

@codecov
Copy link

codecov bot commented Jul 9, 2019

Codecov Report

Merging #2324 into master will increase coverage by 5.5%.
The diff coverage is 77.77%.

Impacted Files Coverage Δ
cmd/skaffold/app/cmd/cmd.go 69.36% <77.77%> (+4.66%) ⬆️
pkg/skaffold/docker/image_util.go 0% <0%> (-33.34%) ⬇️
pkg/skaffold/docker/remote.go 35.41% <0%> (-27.09%) ⬇️
pkg/skaffold/build/bazel/dependencies.go 80.76% <0%> (-12.57%) ⬇️
pkg/skaffold/util/port.go 85.18% <0%> (-7.41%) ⬇️
pkg/skaffold/build/cluster/logs.go 15.15% <0%> (-4.85%) ⬇️
cmd/skaffold/app/cmd/debug.go 50% <0%> (-4.55%) ⬇️
pkg/skaffold/schema/v1beta9/upgrade.go 85.71% <0%> (-3.33%) ⬇️
pkg/skaffold/schema/profiles.go 86.2% <0%> (-1.48%) ⬇️
pkg/skaffold/runner/build_deploy.go 51.35% <0%> (-1.43%) ⬇️
... and 53 more

@dgageot dgageot merged commit 2edef69 into GoogleContainerTools:master Jul 9, 2019
@medyagh medyagh deleted the cmd_help_grouping branch July 9, 2019 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants