Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure we mute/unmute logs at the correct times #2592

Merged
merged 1 commit into from
Aug 2, 2019
Merged

Make sure we mute/unmute logs at the correct times #2592

merged 1 commit into from
Aug 2, 2019

Conversation

nkubala
Copy link
Contributor

@nkubala nkubala commented Jul 31, 2019

This change makes sure that in the dev loop, we:

  • only mute logs whenever we're going to perform an action, and
  • only unmute logs when we've successfully performed an action

Fixes #2530

@codecov
Copy link

codecov bot commented Aug 1, 2019 •
edited
Loading

Codecov Report

Merging #2592 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted Files Coverage Δ
pkg/skaffold/kubernetes/log.go 38.93% <ø> (ø) ⬆️
pkg/skaffold/runner/dev.go 67.61% <100%> (+1.61%) ⬆️
pkg/skaffold/jib/jib.go 77.41% <0%> (-1.08%) ⬇️

balopat
balopat suggested changes Aug 2, 2019
View reviewed changes
pkg/skaffold/runner/dev.go Show resolved Hide resolved
@balopat balopat changed the base branch from master to release/v0.35.0 August 2, 2019 20:26
@balopat balopat merged commit 1903df3 into GoogleContainerTools:release/v0.35.0 Aug 2, 2019
@balopat balopat mentioned this pull request Aug 2, 2019
Merged
@nkubala nkubala mentioned this pull request Aug 12, 2019
Closed
@nkubala nkubala deleted the unmute-logs branch October 17, 2019 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat balopat approved these changes

@dgageot dgageot Awaiting requested review from dgageot

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nkubala @balopat @googlebot