Add port forwarding integration test #2623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tests makes sure that port forwarding works as expected. It then deletes all pods, and makes sure that port forwarding comes back upon the same port.
priyawadhwa
requested review from
balopat,
dgageot,
nkubala and
tejal29
as code owners
priyawadhwa
commented
Aug 9, 2019
| "github.com/GoogleContainerTools/skaffold/pkg/skaffold/util" | ||
| ) | ||
|
|
||
| func TestPortForward(t *testing.T) { |
There was a problem hiding this comment.
This test was copied and pasted from the deleted file white_box_test.go
priyawadhwa
force-pushed
the
integration
branch
from
ed8ff1f to
7df1787
Compare
priyawadhwa
force-pushed
the
integration
branch
from
7df1787 to
12c47e3
Compare
Codecov Report
|
tejal29
reviewed
Aug 9, 2019
| t.Fatalf("error deleting all pods: %v \n %s", err, string(output)) | ||
| } | ||
| // port forwarding should come up again on the same port | ||
| assertResponseFromPort(t, localPort, constants.LeeroyAppResponse) |
There was a problem hiding this comment.
Can you run this test 100 times and make sure there are no flakes.
"INTEGRATION_TEST_ARGS="-test.run ^TestPortForwardDeletePod --test.count 100" make integration
There was a problem hiding this comment.
Good idea -- for some reason my laptop gets really slow when running tests, so I ran 20 (~20 min) and it passed against Minikube.
tejal29
reviewed
Aug 9, 2019
integration/dev_test.go
Outdated
| case <-ctx.Done(): | ||
| t.Fatalf("Timed out waiting for response from port %d", port) | ||
|
|
||
| default: |
There was a problem hiding this comment.
you could also change this too
select {
case <-ctx.Done():
t.Fatalf("Timed out waiting for response from port %d", port)
case <- time.After(1* time.Sleep):
You can also create a timer and re-use (by resetting) the same one to avoid creating new channel time.After
tejal29
approved these changes
Aug 9, 2019
tejal29
approved these changes
Aug 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tests makes sure that port forwarding works as expected. It then
deletes all pods, and makes sure that port forwarding comes back
upon the same port.
First of a few tests for #2596