Update cache-artifacts option usage language to reflect new default #2711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demisx
requested review from
balopat,
dgageot,
nkubala,
priyawadhwa and
tejal29
as code owners
balopat
suggested changes
Aug 23, 2019
| @@ -116,7 +116,7 @@ Examples: | |||
|
|
|||
| Options: | |||
| -b, --build-image=[]: Choose which artifacts to build. Artifacts with image names that contain the expression will be built only. Default is to build sources for all artifacts | |||
| --cache-artifacts=true: Set to true to enable caching of artifacts | |||
| --cache-artifacts=false: Set to false to disable default caching of artifacts | |||
There was a problem hiding this comment.
-
this file is generated using
hack/generate-man.sh, so please revert the manual changes, run that script and commit the results! -
Also, the default value is put in
--cache-artifacts=truewhich istruecurrently. I would still want to leave that there.
There was a problem hiding this comment.
Got it. I kinda had a feeling that I was doing something silly. Anyway, I've followed your instructions and seems to me that I've ended up with similar updated _index.md at the end. Maybe I am missing something. I made a separate commit after each step. Please review.
balopat
approved these changes
Aug 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
--cache-artifactsoption usage language to be more accurate since now artifact caching is on by default.