Improve helm deployer #2772
Merged
Improve helm deployer #2772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dgageot
commented
Aug 30, 2019
dgageot
commented
- Cleanup/Simplify code
- Simplify samples
- Add sync to one of the samples
- Fix all issues related to improper tags/digests (to be verified)
- Streamline logs
Codecov Report
|
dgageot
requested review from
balopat,
nkubala,
priyawadhwa and
tejal29
as code owners
This was referenced Aug 30, 2019
balopat
reviewed
Aug 31, 2019
pkg/skaffold/deploy/helm.go
Outdated
| @@ -302,71 +299,64 @@ func (h *HelmDeployer) deployRelease(ctx context.Context, out io.Writer, r lates | |||
| if len(r.SetValueTemplates) != 0 { | |||
| envMap := map[string]string{} | |||
| for idx, b := range builds { | |||
| m := createEnvVarMap(b.ImageName, b.Tag) | |||
There was a problem hiding this comment.
Why do we even need this variable? We could just inline it, right?
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.