Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add example for skaffold generate-pipeline #2822

Merged
merged 4 commits into from
Sep 6, 2019
Merged

add example for skaffold generate-pipeline #2822

merged 4 commits into from
Sep 6, 2019

Conversation

marlon-gamez
Copy link
Contributor

@marlon-gamez marlon-gamez commented Sep 5, 2019 •
edited
Loading

Add a simple example to give users an idea of how to use the command

@codecov
Copy link

codecov bot commented Sep 5, 2019 •
edited
Loading

Codecov Report

Merging #2822 into master will not change coverage.
The diff coverage is n/a.

tejal29
tejal29 reviewed Sep 5, 2019
View reviewed changes
Copy link
Contributor

@tejal29 tejal29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this to integration/examples/generate-pipeline and include it in your existing integration test?

@marlon-gamez marlon-gamez marked this pull request as ready for review September 6, 2019 19:58
@marlon-gamez
Copy link
Contributor Author

@tejal29 done!

@tejal29 tejal29 added the docs-modifications runs the docs preview service on the given PR label Sep 6, 2019
@container-tools-bot
Copy link

Please visit http://35.236.97.255:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Sep 6, 2019
@tejal29 tejal29 merged commit 3f38e1d into GoogleContainerTools:master Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tejal29 tejal29 tejal29 approved these changes

@balopat balopat Awaiting requested review from balopat

@dgageot dgageot Awaiting requested review from dgageot

@nkubala nkubala Awaiting requested review from nkubala

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@marlon-gamez @container-tools-bot @tejal29 @googlebot @MarlonGamez