Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --config-files flag for generate-pipeline command (v2) #2832

Merged
merged 2 commits into from
Sep 6, 2019
Merged

Add --config-files flag for generate-pipeline command (v2) #2832

merged 2 commits into from
Sep 6, 2019

Conversation

marlon-gamez
Copy link
Contributor

@marlon-gamez marlon-gamez commented Sep 6, 2019 •
edited
Loading

Redo of #2766 with unit test fix

@MarlonGamez
Revert "Merge pull request GoogleContainerTools#2825 from GoogleConta…
b23d1fc 
…inerTools/revert-2766-config-files-flag"

This reverts commit 02509f7, reversing
changes made to a977c83.
@marlon-gamez marlon-gamez changed the title fixing broken tests...experimenting with git... Add --config-files flag for generate-pipeline command (v2) Sep 6, 2019
@codecov
Copy link

codecov bot commented Sep 6, 2019 •
edited
Loading

Codecov Report

Merging #2832 into master will decrease coverage by 0.13%.
The diff coverage is 30.3%.

Impacted Files Coverage Δ
pkg/skaffold/runner/runner.go 0% <ø> (ø) ⬆️
pkg/skaffold/runner/generate_pipeline.go 0% <0%> (ø) ⬆️
pkg/skaffold/generate_pipeline/tasks.go 76.92% <100%> (+0.51%) ⬆️
...kg/skaffold/generate_pipeline/generate_pipeline.go 40.25% <100%> (+0.78%) ⬆️
cmd/skaffold/app/cmd/generate_pipeline.go 57.14% <75%> (+7.14%) ⬆️

@tejal29 tejal29 merged commit d07374b into GoogleContainerTools:master Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tejal29 tejal29 tejal29 approved these changes

@balopat balopat Awaiting requested review from balopat

@dgageot dgageot Awaiting requested review from dgageot

@nkubala nkubala Awaiting requested review from nkubala

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marlon-gamez @tejal29 @googlebot @MarlonGamez