Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor pollDeploymentRolloutStatus #2846

Merged
merged 1 commit into from
Sep 9, 2019
Merged

refactor pollDeploymentRolloutStatus #2846

merged 1 commit into from
Sep 9, 2019

Conversation

tejal29
Copy link
Contributor

@tejal29 tejal29 commented Sep 9, 2019

Related to #176

No user output changes.

@tejal29 tejal29 mentioned this pull request Sep 9, 2019
Merged
7 tasks
@codecov
Copy link

codecov bot commented Sep 9, 2019

Codecov Report

Merging #2846 into master will decrease coverage by 0.02%.
The diff coverage is 66.66%.

Impacted Files Coverage Δ
pkg/skaffold/deploy/status_check.go 59.37% <66.66%> (-3.87%) ⬇️

balopat
balopat approved these changes Sep 9, 2019
View reviewed changes
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@balopat balopat merged commit 9d0fcd6 into GoogleContainerTools:master Sep 9, 2019
@tejal29 tejal29 deleted the refactor-break-3 branch September 18, 2019 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkubala nkubala nkubala approved these changes

@balopat balopat balopat approved these changes

@dgageot dgageot Awaiting requested review from dgageot

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tejal29 @balopat @nkubala @googlebot