Optional secret #2897
Optional secret #2897
Conversation
prary
requested review from
balopat,
dgageot,
nkubala,
priyawadhwa and
tejal29
as code owners
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
| @@ -210,13 +210,13 @@ func setDefaultClusterTimeout(cluster *latest.ClusterDetails) error { | |||
| } | |||
|
|
|||
| func setDefaultClusterPullSecret(cluster *latest.ClusterDetails) error { | |||
| cluster.PullSecretName = valueOrDefault(cluster.PullSecretName, constants.DefaultKanikoSecretName) | |||
| if cluster.PullSecret != "" { | |||
There was a problem hiding this comment.
| if cluster.PullSecret != "" { | |
| if cluster.PullSecret != "" && cluster.PullSecretName != "" { |
There was a problem hiding this comment.
cluster.PullSecretName != ""
this could be skipped by user when user wants pullsecret to be created as constants.DefaultKanikoSecretName i.e kaniko-secret.
observe the below line
cluster.PullSecretName = valueOrDefault(cluster.PullSecretName, constants.DefaultKanikoSecretName)
| }, | ||
| } | ||
| if clusterDetails.PullSecretName != "" { | ||
| VolumeMount := v1.VolumeMount{ |
There was a problem hiding this comment.
nit: let's call this variable volumeMount to match current style
| MountPath: "/secret", | ||
| } | ||
| pod.Spec.Containers[0].VolumeMounts = append(pod.Spec.Containers[0].VolumeMounts, VolumeMount) | ||
| Volume := v1.Volume{ |
There was a problem hiding this comment.
nit: call this variable v or volume
pull secret should be optional
Resolving issue #2888