[WIP] fix deploy logging #2987
Closed
[WIP] fix deploy logging #2987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balopat
commented
Oct 4, 2019
| @@ -92,6 +92,7 @@ func (r *SkaffoldRunner) DeployAndLog(ctx context.Context, out io.Writer, artifa | |||
| var imageNames []string | |||
| for _, artifact := range artifacts { | |||
| imageNames = append(imageNames, artifact.ImageName) | |||
| r.podSelector.Add(artifact.Tag) | |||
There was a problem hiding this comment.
this is the fix, it's a one line change. Testing it is a bit more involved, hence the rest of the PR.
4 tasks
balopat
force-pushed
the
fix_deploy_logging
branch
from
5c831e9 to
f405b25
Compare
|
@dgageot finished this, yay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2981.
Description
skaffold deploy --tailis broken, this fixes it: the reason is that we don't add the image names to the podSelector (runner.imageList).TODO:
*kubernetes.LogAggregatorpodSelector, adding unit test for logging + unit test & fix for deploy-only changeUser facing changes
Before
skaffold deploy --tailis not logging.After
skaffold deploy --tailwill log again!Also added some TRACE level logs for debugging.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Reviewer Notes
Release Notes