Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate file sync events into dev command #3009

Merged
merged 1 commit into from
Oct 21, 2019
Merged

Integrate file sync events into dev command #3009

merged 1 commit into from
Oct 21, 2019

Conversation

Multiply
Copy link
Contributor

@Multiply Multiply commented Oct 7, 2019

Relates to #2978

Should merge after : #2978

Description

Implements the file sync events from #2978 into the dev flow

User facing changes

n/a

Next PRs.

n/a

Submitter Checklist

  • Includes unit tests
  • Mentions any output changes.
  • Adds documentation as needed: user docs, YAML reference, CLI reference.
  • Adds integration tests if needed.

Reviewer Notes

  • The code flow looks good.
  • Unit test added.
  • User facing changes look good.

Release Notes

New features:
- Implement file sync events from #2978

@Multiply
Copy link
Contributor Author

Multiply commented Oct 7, 2019

This PR should be rebased when #2978 is merged.

@Multiply Multiply changed the title File sync events with dev Integrate file sync events into dev command Oct 7, 2019
@Multiply Multiply mentioned this pull request Oct 7, 2019
Merged
7 tasks
@codecov
Copy link

codecov bot commented Oct 7, 2019 •
edited
Loading

Codecov Report

Merging #3009 into master will increase coverage by <.01%.
The diff coverage is 80%.

Impacted Files Coverage Δ
pkg/skaffold/runner/dev.go 68.22% <80%> (+0.26%) ⬆️

@Multiply Multiply force-pushed the file-sync-events-with-dev branch from 050faac to b82f13d Compare October 9, 2019 06:23
@Multiply
Copy link
Contributor Author

Multiply commented Oct 9, 2019

Rebased against #2978 after fixing review comments.

@tejal29 tejal29 added the kokoro:run runs the kokoro jobs on a PR label Oct 9, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Oct 9, 2019
@Multiply Multiply force-pushed the file-sync-events-with-dev branch from b82f13d to e1097a7 Compare October 10, 2019 06:53
@Multiply
Copy link
Contributor Author

@tejal29 I've rebased against latest master.

@tejal29 tejal29 added the kokoro:run runs the kokoro jobs on a PR label Oct 18, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Oct 18, 2019
@tejal29 tejal29 merged commit 5011419 into GoogleContainerTools:master Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tejal29 tejal29 tejal29 approved these changes

@balopat balopat Awaiting requested review from balopat

@dgageot dgageot Awaiting requested review from dgageot

@nkubala nkubala Awaiting requested review from nkubala

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

Assignees
No one assigned
Labels
cla: yes size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Multiply @tejal29 @googlebot @kokoro-team