Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix remove patch in Profiles #3045

Merged
merged 1 commit into from
Oct 14, 2019
Merged

Fix remove patch in Profiles #3045

merged 1 commit into from
Oct 14, 2019

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Oct 14, 2019

Fix #3044

Signed-off-by: David Gageot david@gageot.net

@dgageot
Fix remove patch in Propfiles
859fadc 
Fix GoogleContainerTools#3044

Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot mentioned this pull request Oct 14, 2019
Closed
@codecov
Copy link

codecov bot commented Oct 14, 2019 •
edited
Loading

Codecov Report

Merging #3045 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted Files Coverage Δ
pkg/skaffold/schema/profiles.go 88.57% <100%> (+0.06%) ⬆️

nkubala
nkubala approved these changes Oct 14, 2019
View reviewed changes
Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooh good catch

@dgageot dgageot merged commit b0f9d08 into GoogleContainerTools:master Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkubala nkubala nkubala approved these changes

@balopat balopat Awaiting requested review from balopat

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to remove a section with a Profile using a remove patch
3 participants
@dgageot @nkubala @googlebot