Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate more linters #3057

Merged
merged 2 commits into from
Oct 16, 2019
Merged

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Oct 15, 2019

  • dogsled: Checks assignments with too many blank identifiers (e.g. x, _, _, _, := f())
  • nakedret: Finds naked returns in functions greater than a specified function length
  • whitespace: Tool for detection of leading and trailing whitespace

Signed-off-by: David Gageot david@gageot.net

@codecov
Copy link

codecov bot commented Oct 15, 2019

Codecov Report

Merging #3057 into master will not change coverage.
The diff coverage is n/a.

Impacted Files Coverage Δ
cmd/skaffold/app/cmd/config.go 100% <ø> (ø) ⬆️
pkg/skaffold/build/parallel.go 94.36% <ø> (ø) ⬆️
pkg/skaffold/build/local/local.go 33.33% <ø> (ø) ⬆️
pkg/skaffold/jib/jib_gradle.go 100% <ø> (ø) ⬆️
pkg/skaffold/build/cluster/secret.go 36.2% <ø> (ø) ⬆️
pkg/skaffold/debug/debug.go 43.33% <ø> (ø) ⬆️
pkg/skaffold/build/custom/custom.go 62.5% <ø> (ø) ⬆️
pkg/skaffold/docker/client.go 73.73% <ø> (ø) ⬆️
pkg/skaffold/docker/auth.go 55.76% <ø> (ø) ⬆️
pkg/skaffold/build/cache/hash.go 72.3% <ø> (ø) ⬆️
... and 76 more

Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Copy link
Contributor

@tejal29 tejal29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dgageot.
Can you please specify what each of the linters you activated do?

    - dogsled
    - nakedret
    - whitespace

@dgageot
Copy link
Contributor Author

dgageot commented Oct 16, 2019

@tejal29 description added

Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, sounds good, thank you!

@balopat balopat merged commit 46c941b into GoogleContainerTools:master Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants