Log durations instead of always printing them #3102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgageot
force-pushed
the
log-durations
branch
from
ce121cd to
b34e270
Compare
Codecov Report
|
nkubala
approved these changes
Oct 21, 2019
Signed-off-by: David Gageot <david@gageot.net>
dgageot
force-pushed
the
log-durations
branch
from
b34e270 to
508f41c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR to simplify Skaffold's output.
This one is simple, it hides the timings that are currently always shown, and log them at Info level.
Before:
After:
Signed-off-by: David Gageot david@gageot.net