Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with tagging of insecure registries. #3127

Merged
merged 1 commit into from
Oct 31, 2019

Conversation

NicklasWallgren
Copy link
Contributor

Fixes #2986

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@codecov
Copy link

codecov bot commented Oct 25, 2019

Codecov Report

Merging #3127 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted Files Coverage Δ
pkg/skaffold/docker/remote.go 12.96% <0%> (-1.04%) ⬇️

@dgageot dgageot added the kokoro:run runs the kokoro jobs on a PR label Oct 31, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Oct 31, 2019
@balopat balopat merged commit d685e42 into GoogleContainerTools:master Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Reappeared] Build and push to an insecure registry completes unsuccessfully
5 participants