Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix writing rendered manifests to files #3152

Merged
merged 1 commit into from
Nov 1, 2019

Conversation

nkubala
Copy link
Contributor

@nkubala nkubala commented Nov 1, 2019

before this change, trying to run skaffold render --output file.txt would fail with

FATA[0001] rendering manifests: opening file for writing manifests: open file.txt: no such file or directory

this was happening because we were trying to do an os.Open() on a file that didn't exist. now, we'll just do an os.OpenFile() with the right opening mode, and just call file.WriteString() rather than creating a new Writer.

@codecov
Copy link

codecov bot commented Nov 1, 2019

Codecov Report

Merging #3152 into master will decrease coverage by <.01%.
The diff coverage is 40%.

Impacted Files Coverage Δ
pkg/skaffold/deploy/kubectl.go 63.97% <40%> (-0.21%) ⬇️

@tejal29 tejal29 merged commit a73727d into GoogleContainerTools:master Nov 1, 2019
@nkubala nkubala deleted the fix-render branch November 4, 2019 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants