Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add healthcheck #3178

Merged
merged 5 commits into from
Nov 6, 2019
Merged

[docs] Add healthcheck #3178

merged 5 commits into from
Nov 6, 2019

Conversation

tejal29
Copy link
Contributor

@tejal29 tejal29 commented Nov 5, 2019 •
edited
Loading

Relates to #176

See docs in workflow/ci-cd

Merge after: #3177

@tejal29 tejal29 added priority/p0 Highest priority. We are actively looking at delivering it. docs-modifications runs the docs preview service on the given PR and removed size/L labels Nov 5, 2019
@container-tools-bot
Copy link

Please visit http://35.236.87.39:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Nov 5, 2019
@codecov
Copy link

codecov bot commented Nov 5, 2019 •
edited
Loading

Codecov Report

Merging #3178 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted Files Coverage Δ
pkg/skaffold/jib/jib_init.go 88.13% <0%> (-1.42%) ⬇️
pkg/skaffold/util/tar.go 47.87% <0%> (+4.25%) ⬆️

dgageot
dgageot previously requested changes Nov 6, 2019
View reviewed changes
docs/content/en/docs/workflows/ci-cd.md Outdated Show resolved Hide resolved
docs/content/en/docs/workflows/ci-cd.md Outdated Show resolved Hide resolved
docs/content/en/docs/workflows/ci-cd.md Outdated Show resolved Hide resolved
balopat
balopat previously requested changes Nov 6, 2019
View reviewed changes
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after a couple of nits

@tejal29 @balopat
Apply suggestions from code review
ddd5952 
Co-Authored-By: Balint Pato <balopat@users.noreply.github.com>
@tejal29 tejal29 added the docs-modifications runs the docs preview service on the given PR label Nov 6, 2019
@container-tools-bot
Copy link

Please visit http://34.94.43.151:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Nov 6, 2019
nkubala
nkubala reviewed Nov 6, 2019
View reviewed changes
docs/content/en/docs/workflows/ci-cd.md Outdated Show resolved Hide resolved
docs/content/en/docs/workflows/ci-cd.md Outdated Show resolved Hide resolved
docs/content/en/docs/workflows/ci-cd.md Outdated Show resolved Hide resolved
docs/content/en/docs/workflows/ci-cd.md Outdated Show resolved Hide resolved
docs/content/en/docs/workflows/ci-cd.md Outdated Show resolved Hide resolved
docs/content/en/docs/workflows/ci-cd.md Outdated Show resolved Hide resolved
docs/content/en/docs/workflows/ci-cd.md Outdated Show resolved Hide resolved
docs/content/en/docs/workflows/ci-cd.md Outdated Show resolved Hide resolved
docs/content/en/docs/workflows/ci-cd.md Outdated Show resolved Hide resolved
docs/content/en/docs/workflows/ci-cd.md Outdated Show resolved Hide resolved
@tejal29 @nkubala
Apply suggestions from code review
657f86f 
Co-Authored-By: Nick Kubala <nkubala@users.noreply.github.com>
@tejal29 tejal29 merged commit 5f66591 into master Nov 6, 2019
@dgageot dgageot deleted the add_healthcheck branch November 18, 2019 12:24
@pull-request-size pull-request-size bot added size/M and removed size/L labels Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkubala nkubala nkubala approved these changes

@balopat balopat balopat left review comments

@dgageot dgageot dgageot left review comments

Assignees
No one assigned
Labels
area/status-check cla: yes priority/p0 Highest priority. We are actively looking at delivering it. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tejal29 @container-tools-bot @dgageot @balopat @nkubala @googlebot