Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[buildpacks] Run cleanup on ctrl-c #3184

Merged
merged 1 commit into from
Nov 6, 2019
Merged

[buildpacks] Run cleanup on ctrl-c #3184

merged 1 commit into from
Nov 6, 2019

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Nov 6, 2019

Signed-off-by: David Gageot david@gageot.net

@dgageot
[buildpacks] Run cleanup on ctrl-c
2625502 
Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot force-pushed the fix-buildpacks-cleanup branch from 665a933 to 2625502 Compare November 6, 2019 11:16
@codecov
Copy link

codecov bot commented Nov 6, 2019 •
edited
Loading

Codecov Report

Merging #3184 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted Files Coverage Δ
pkg/skaffold/build/buildpacks/lifecycle.go 81.81% <0%> (ø) ⬆️
pkg/skaffold/docker/containers.go 66.66% <0%> (ø) ⬆️
pkg/skaffold/util/tar.go 43.61% <0%> (-4.26%) ⬇️

@balopat balopat merged commit a9c2630 into GoogleContainerTools:master Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat balopat approved these changes

@nkubala nkubala Awaiting requested review from nkubala

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgageot @balopat @googlebot