Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env vars to kaniko specs #3389

Merged
merged 1 commit into from
Dec 18, 2019
Merged

Conversation

cyrildiagne
Copy link
Contributor

Rebase of #3115
Relates to #731

Fixes #731.

Description

This will give users the option to provide environment variables to the kaniko pod.
This should fix #731 and enable ECR support on regions other than the default one.

User facing changes

n/a

Next PRs.

n/a

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Mentions any output changes.
  • Adds documentation as needed: user docs, YAML reference, CLI reference.
  • Adds integration tests if needed.

Reviewer Notes

  • The code flow looks good.
  • Unit test added.
  • User facing changes look good.

Release Notes

@codecov
Copy link

codecov bot commented Dec 15, 2019

Codecov Report

Merging #3389 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted Files Coverage Δ
pkg/skaffold/schema/latest/config.go 100% <ø> (ø) ⬆️
pkg/skaffold/build/cluster/sources/sources.go 91.89% <100%> (+0.3%) ⬆️

@balopat balopat added the kokoro:run runs the kokoro jobs on a PR label Dec 18, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Dec 18, 2019
@balopat balopat merged commit 9b49f0c into GoogleContainerTools:master Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skaffold/Kaniko with ECR
4 participants