Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply resource labels in the deployer #3390

Merged

Conversation

corneliusweig
Copy link
Contributor

@corneliusweig corneliusweig commented Dec 16, 2019

Relates to #2875, #3292

Should merge before : #3392

Description

This prepares for having multiple deployers per skaffold.yaml, and
ensures that every resource has the label of the proper deployer it was
deployed with.

User facing changes

n/a

Next PRs.

  • add a deployer implementation that handles multiple deployers (i.e. kubectl, kustomize, helm)
  • adapt skaffold.yaml to accept multiple deployer configurations in the deploy field.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Mentions any output changes.
  • Adds documentation as needed: user docs, YAML reference, CLI reference.
  • Adds integration tests if needed.

Reviewer Notes

  • The code flow looks good.
  • Unit test added.
  • User facing changes look good.

This prepares for having multiple deployers per skaffold.yaml, and
ensures that every resource has the label of the proper deployer it was
deployed with.
@codecov
Copy link

codecov bot commented Dec 16, 2019

Codecov Report

Merging #3390 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted Files Coverage Δ
pkg/skaffold/deploy/labels.go 9.75% <100%> (-6.1%) ⬇️
pkg/skaffold/runner/new.go 69.28% <100%> (ø) ⬆️
pkg/skaffold/deploy/kubectl.go 63.7% <100%> (ø) ⬆️
pkg/skaffold/deploy/helm.go 78.41% <100%> (+1.07%) ⬆️
pkg/skaffold/deploy/kustomize.go 76.61% <100%> (+2.41%) ⬆️

@dgageot dgageot added the kokoro:run runs the kokoro jobs on a PR label Dec 16, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Dec 16, 2019
@dgageot dgageot merged commit 099d302 into GoogleContainerTools:master Dec 16, 2019
@corneliusweig corneliusweig deleted the w/deployer-mux/labels branch December 17, 2019 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants