Fix `skaffold credits` #3436

dgageot · 2019-12-24T09:35:49Z

codecov · 2019-12-24T09:42:16Z

Codecov Report

Merging #3436 into master will increase coverage by 0.04%.
The diff coverage is 57.14%.

Impacted Files	Coverage Δ
cmd/skaffold/app/cmd/credits/export.go	`0% <0%> (ø)`	⬆️
cmd/skaffold/app/cmd/schema/print.go	`80% <100%> (ø)`	⬆️
...affold/kubernetes/portforward/kubectl_forwarder.go	`65.85% <0%> (-2.44%)`	⬇️
pkg/skaffold/util/tar.go	`57.47% <0%> (+4.59%)`	⬆️

Signed-off-by: David Gageot <david@gageot.net>

Generate a single statik.go file that embeds both credits and schemas. Fixes GoogleContainerTools#3428

googlebot added the cla: yes label Dec 24, 2019

pull-request-size bot added the size/M label Dec 24, 2019

dgageot added 3 commits December 24, 2019 11:09

Add an integration test for skaffold schema

865c3f5

Signed-off-by: David Gageot <david@gageot.net>

Add an integration test for skaffold credits

a11a36c

Signed-off-by: David Gageot <david@gageot.net>

Fix skaffold credits

efff827

Generate a single statik.go file that embeds both credits and schemas. Fixes GoogleContainerTools#3428

dgageot force-pushed the fix-credits branch from 7f331ba to efff827 Compare December 24, 2019 10:13

pull-request-size bot added size/L and removed size/M labels Dec 24, 2019

dgageot marked this pull request as ready for review December 24, 2019 10:34

dgageot requested review from balopat, nkubala and tejal29 as code owners December 24, 2019 10:34

dgageot mentioned this pull request Dec 24, 2019

Simpler credits #3444

Closed

balopat approved these changes Jan 3, 2020

View reviewed changes

balopat merged commit d5b16c9 into GoogleContainerTools:master Jan 3, 2020