Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename jib args functions #3478

Merged
merged 1 commit into from
Jan 7, 2020
Merged

Rename jib args functions #3478

merged 1 commit into from
Jan 7, 2020

Conversation

loosebazooka
Copy link
Member

GenerateMavenArgs -> GenerateMavenBuildArgs
GenerateGradleArgs -> GenerateGradleBuildArgs

@codecov
Copy link

codecov bot commented Jan 7, 2020 •
edited
Loading

Codecov Report

Merging #3478 into master will not change coverage.
The diff coverage is 100%.

Impacted Files Coverage Δ
pkg/skaffold/build/jib/maven.go 100% <100%> (ø) ⬆️
pkg/skaffold/build/jib/gradle.go 100% <100%> (ø) ⬆️
pkg/skaffold/build/gcb/jib.go 84% <100%> (ø) ⬆️

chanseokoh
chanseokoh approved these changes Jan 7, 2020
View reviewed changes
Copy link
Member

@chanseokoh chanseokoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope this is going in the right direction. The other day, I realized many methods in the package are similarly named and are confusing. Note https://github.com/GoogleContainerTools/skaffold/pull/3369/files#diff-af0afb6f5883c110219e4d725f41a0ddR88 adds another method.

@loosebazooka loosebazooka merged commit 19a4dec into master Jan 7, 2020
@dgageot dgageot deleted the rename-jib-args-functions branch May 11, 2020 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chanseokoh chanseokoh chanseokoh approved these changes

@dgageot dgageot dgageot approved these changes

@balopat balopat Awaiting requested review from balopat

@briandealwis briandealwis Awaiting requested review from briandealwis

@nkubala nkubala Awaiting requested review from nkubala

@TadCordle TadCordle Awaiting requested review from TadCordle

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@loosebazooka @dgageot @chanseokoh @googlebot