Kaniko: Cancel log streaming when pod fails to complete #3481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedrickring
requested review from
balopat,
dgageot,
nkubala and
tejal29
as code owners
cedrickring
changed the title
|
@cedrickring Sorry for that. There was an issue when the build was timing out. |
dgageot
approved these changes
Jan 8, 2020
Codecov Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3238 basically reverted the changes I did in #2352. @dgageot
Description
Right now if a Kaniko build fails immediately after starting the pod, the user sees no output.
Before
No log output when Kaniko pod fails immediately.
After
Log output when Kaniko pod fails immediately.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Reviewer Notes