[doc] Improve documentation for concurrency settings. #3491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgageot
added
docs-modifications
container-tools-bot
removed
the
docs-modifications
|
Please visit http://35.235.83.81:1313 to view changes to the docs. |
Codecov Report
|
dgageot
changed the title
|
|
||
| Skaffold can also build multiple artifacts in parallel, by settings a value higher than `1` to `concurrency`. | ||
| For local builds, this is however disabled by default since local builds could have side effects that are |
There was a problem hiding this comment.
Do you think we should mention specific builders that are believed to be safe (docker, Bazel) or that aren't safe (and the circumstances)?
| **Faster builds** | ||
|
|
||
| If you are deploying to [local cluster]({{<relref "/docs/environment/local-cluster" >}}), | ||
| Skaffold will default `push` to `false` to speed up builds. |
There was a problem hiding this comment.
I wonder if we should expand on this paragraph because there are a few implications.
- certain clusters, like minikube, kind, Docker Kubernetes, are considered as local clusters
- Skaffold can usually load the images directly into a local cluster, instead of via an image registry
- local clusters change the default for push to
falseto avoid pushing the image to the remote repository - this means that the same builds can fail when switching the kube context to a remote cluster. but the speed tradeoff is worth it.
And maybe Faster builds isn't the right section heading either.
There was a problem hiding this comment.
I'm happy to add some more documentation when most of this is merged :-)
dgageot
force-pushed
the
concurrency-doc
branch
from
60f40a1 to
cbbf598
Compare
This comment has been minimized.
This comment has been minimized.
dgageot
force-pushed
the
concurrency-doc
branch
from
cbbf598 to
684e553
Compare
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
dgageot
force-pushed
the
concurrency-doc
branch
from
684e553 to
6617e6e
Compare
Signed-off-by: David Gageot <david@gageot.net>
dgageot
force-pushed
the
concurrency-doc
branch
from
6617e6e to
bc503c6
Compare
nkubala
approved these changes
Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See http://35.235.83.81:1313/docs/pipeline-stages/builders/#local-build
Signed-off-by: David Gageot david@gageot.net