skip-build shouldn't detect builders #3528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
dgageot
approved these changes
Jan 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
--skip-buildis passed in,skaffold initshould just skip artifacts section in the skaffold.yaml. This works, however currently we still traverse into the subdirectories and detect all the builders! This PR removes that issue.Note: There is no significant time diff on my laptop weirdly on the skaffold repo between master and this version. Maybe I'm missing something, or artifact detection is fast...
This also helps moving the design toward a visitor pattern, where I could turn on and off certain visitors that aggregate the state independently in the
analysisstruct.