Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

init refactor/clearer k8s manifest parsing #3531

Merged
merged 2 commits into from
Jan 19, 2020
Merged

init refactor/clearer k8s manifest parsing #3531

merged 2 commits into from
Jan 19, 2020

Conversation

balopat
Copy link
Contributor

@balopat balopat commented Jan 19, 2020 •
edited
Loading

small refactoring, cleanup in parsing k8s yamls in skaffold init.
The main changes:

  • introduce yamlObject type alias for readability
  • split out image parsing from yaml parsing into a single responsibility function parseKubernetesObjects and then using that in Kubernetes manifest file detection instead of image parsing

@codecov
Copy link

codecov bot commented Jan 19, 2020 •
edited
Loading

Codecov Report

Merging #3531 into master will increase coverage by <.01%.
The diff coverage is 95.83%.

Impacted Files Coverage Δ
pkg/skaffold/util/util.go 86.48% <100%> (ø) ⬆️
pkg/skaffold/deploy/kubectl.go 65.87% <100%> (ø) ⬆️
pkg/skaffold/initializer/kubectl/kubectl.go 84.61% <95.45%> (+1.28%) ⬆️
pkg/skaffold/initializer/init.go 29.12% <0%> (-0.29%) ⬇️

@balopat balopat merged commit 2ba2af8 into GoogleContainerTools:master Jan 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgageot dgageot dgageot approved these changes

@nkubala nkubala Awaiting requested review from nkubala

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@balopat @dgageot @googlebot