Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golangci-lint #3534

Merged
merged 1 commit into from
Jan 20, 2020
Merged

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Jan 20, 2020

Also make sure we alway use the version we’ve just installed.

Signed-off-by: David Gageot david@gageot.net

@codecov
Copy link

codecov bot commented Jan 20, 2020

Codecov Report

Merging #3534 into master will not change coverage.
The diff coverage is n/a.

@@ -7,16 +7,22 @@ linters:
enable:
- bodyclose
- deadcode
- dogsled
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dogsled twice

- gosimple
- govet
- ineffassign
- interfacer
- maligned
- misspell
- nakedret
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nakedret twice

Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with @loosebazooka's nits

Also make sure we alway use the version we’ve just
installed.

Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot force-pushed the bump-golangci-lint branch from aea00a6 to 97236e8 Compare January 20, 2020 15:20
@dgageot dgageot merged commit d0a9b95 into GoogleContainerTools:master Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants