Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nil pointer dereference when no account is set on gcloud. #3597

Merged
merged 1 commit into from
Jan 28, 2020
Merged

Fix nil pointer dereference when no account is set on gcloud. #3597

merged 1 commit into from
Jan 28, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Jan 28, 2020

Fixes #3596

And add unit tests

@dgageot dgageot mentioned this pull request Jan 28, 2020
Closed
@codecov
Copy link

codecov bot commented Jan 28, 2020 •
edited
Loading

Codecov Report

Merging #3597 into master will increase coverage by 0.04%.
The diff coverage is 66.66%.

Impacted Files Coverage Δ
pkg/skaffold/docker/authenticators.go 86.66% <66.66%> (+21.14%) ⬆️
...affold/kubernetes/portforward/kubectl_forwarder.go 65.85% <0%> (-2.44%) ⬇️

@dgageot dgageot merged commit 25fb8fc into GoogleContainerTools:master Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat balopat approved these changes

@nkubala nkubala Awaiting requested review from nkubala

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nil pointer dereference when gcloud is not properly configured
3 participants
@dgageot @balopat @googlebot