Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add profile option to RunBuilder in test helper #3761

Merged
merged 2 commits into from
Mar 1, 2020
Merged

Add profile option to RunBuilder in test helper #3761

merged 2 commits into from
Mar 1, 2020

Conversation

loosebazooka
Copy link
Member

@codecov
Copy link

codecov bot commented Feb 28, 2020 •
edited
Loading

Codecov Report

Merging #3761 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted Files Coverage Δ
pkg/skaffold/util/term.go 50% <0%> (-50%) ⬇️
pkg/skaffold/color/formatter.go 90% <0%> (-10%) ⬇️
...affold/kubernetes/portforward/kubectl_forwarder.go 65.85% <0%> (-2.44%) ⬇️
pkg/skaffold/build/parallel.go 93.93% <0%> (-0.43%) ⬇️
cmd/skaffold/app/cmd/cmd.go 68.46% <0%> (+1.03%) ⬆️

dgageot
dgageot suggested changes Feb 29, 2020
View reviewed changes
integration/skaffold/helper.go Outdated Show resolved Hide resolved
@dgageot dgageot self-assigned this Feb 29, 2020
@loosebazooka @dgageot
Update integration/skaffold/helper.go
76ebb19 
Co-Authored-By: David Gageot <david@gageot.net>
@dgageot dgageot merged commit 54c9796 into master Mar 1, 2020
@fmotrifork fmotrifork mentioned this pull request Mar 11, 2020
Merged
@briandealwis briandealwis deleted the add-profile-option-to-test-helper branch April 14, 2020 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgageot dgageot dgageot approved these changes

@balopat balopat Awaiting requested review from balopat

@nkubala nkubala Awaiting requested review from nkubala

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees

@dgageot dgageot

Labels
cla: yes size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loosebazooka @dgageot @googlebot