unhide status check and on by default #3792

balopat · 2020-03-06T00:06:49Z

Reverts #3791.

The Revert^4.
!!! Only merge after 1.5.0 !!!

…. """"

codecov · 2020-03-06T00:16:32Z

Codecov Report

Merging #3792 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted Files	Coverage Δ
cmd/skaffold/app/cmd/flags.go	`100% <ø> (ø)`	⬆️
...affold/kubernetes/portforward/kubectl_forwarder.go	`68.29% <0%> (+2.43%)`	⬆️

nkubala

👍 👍 👍 👍

Revert "Revert "Revert "Revert "unhide status check and on by default…

294fabc

…. """"

balopat added the !! do-not-merge !! label Mar 6, 2020

googlebot added the cla: yes label Mar 6, 2020

pull-request-size bot added the size/S label Mar 6, 2020

balopat added the pr/blocked label Mar 6, 2020

balopat marked this pull request as ready for review March 6, 2020 22:17

balopat requested review from dgageot, nkubala and tejal29 as code owners March 6, 2020 22:17

balopat added !! do-not-merge !! pr/blocked and removed !! do-not-merge !! pr/blocked labels Mar 6, 2020

nkubala approved these changes Mar 10, 2020

View reviewed changes

nkubala merged commit c9be421 into master Mar 10, 2020

fmotrifork mentioned this pull request Mar 20, 2020

skaffold 1.6.0 fishworks/fish-food#635

Merged

briandealwis deleted the revert-3791-revert-3790-revert-3782-revert-3639-unhide-status-check branch April 14, 2020 15:59