Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues in skaffold init #3840

Merged
merged 5 commits into from
Mar 19, 2020
Merged

Fix issues in skaffold init #3840

merged 5 commits into from
Mar 19, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Mar 19, 2020

  • Close files
  • Don't panic on random yaml files
  • Parse skaffold configs only if they are yaml|yml|json files

dgageot added 2 commits March 19, 2020 17:15
@dgageot
Close files
733ec46 
Signed-off-by: David Gageot <david@gageot.net>
@dgageot
Don’t panic on random yaml files
006f760 
Some yaml files have non-string keys

Signed-off-by: David Gageot <david@gageot.net>
@dgageot
Only check yaml|yml|json files
dd37955 
Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot force-pushed the fix-skaffold-init branch from a6c19dd to dd37955 Compare March 19, 2020 17:43
@codecov
Copy link

codecov bot commented Mar 19, 2020 •
edited
Loading

Codecov Report

Merging #3840 into master will increase coverage by 0.01%.
The diff coverage is 75%.

Impacted Files Coverage Δ
pkg/skaffold/schema/versions.go 75% <100%> (+1.92%) ⬆️
pkg/skaffold/docker/docker_init.go 100% <100%> (ø) ⬆️
pkg/skaffold/initializer/analyze/analyze.go 89.09% <100%> (ø) ⬆️
pkg/skaffold/initializer/init.go 37.2% <50%> (-1.43%) ⬇️
pkg/skaffold/kubernetes/util.go 87.3% <75%> (-2.36%) ⬇️
pkg/skaffold/docker/dependencies.go 75% <0%> (+1.08%) ⬆️

dgageot added 2 commits March 19, 2020 19:36
@dgageot
Quickly check for valid skaffold.yaml
f1cd3f7 
Signed-off-by: David Gageot <david@gageot.net>
@dgageot
Cleanup code
f7b1b30 
Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot merged commit 7e06752 into GoogleContainerTools:master Mar 19, 2020
@fmotrifork fmotrifork mentioned this pull request Mar 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat balopat approved these changes

@nkubala nkubala Awaiting requested review from nkubala

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgageot @balopat @googlebot