Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] [release] fix firebase-tools version #3857

Merged
merged 1 commit into from
Mar 23, 2020

Conversation

balopat
Copy link
Contributor

@balopat balopat commented Mar 22, 2020

Fixes the issues with the Firebase deploys and as such it: Fixes #3847.
The firebase-tools package was always installed from latest - hence Docker build cached it, and never upgraded it, this change makes the version explicit - so we have to keep it up to date. This fixes the Error: An unexpected error has occurred. errors in our Cloud Build firebase deploys.

@codecov
Copy link

codecov bot commented Mar 22, 2020

Codecov Report

Merging #3857 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted Files Coverage Δ
...affold/kubernetes/portforward/kubectl_forwarder.go 65.85% <0%> (-2.44%) ⬇️

@balopat balopat changed the title fix firebase-tools version [docs] [release] fix firebase-tools version Mar 22, 2020
@dgageot dgageot merged commit e9c4111 into GoogleContainerTools:master Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

release process issues with binary uploads & firebase deployment
3 participants