Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move global args to be applied to version call #4171

Closed
wants to merge 4 commits into from
Closed

move global args to be applied to version call #4171

wants to merge 4 commits into from

Conversation

ryanhagen
Copy link

Description
Executing helm version will check the server side namespace kube-system. In my particular use case of skaffold, I will not have access to kube-system, therefore, global variable --tiller-namespace will have to be applied to the helm version command, hence this PR.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@ryanhagen
Copy link
Author

@googlebot I fixed it.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@codecov
Copy link

codecov bot commented May 13, 2020

Codecov Report

Merging #4171 into master will increase coverage by 0.19%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
pkg/skaffold/deploy/helm.go 79.12% <100.00%> (-0.72%) ⬇️
pkg/skaffold/deploy/transformations.go 0.00% <0.00%> (-100.00%) ⬇️
cmd/skaffold/app/cmd/debug.go 50.00% <0.00%> (-50.00%) ⬇️
pkg/skaffold/runner/debugging.go 33.33% <0.00%> (-41.67%) ⬇️
pkg/skaffold/update/update.go 34.37% <0.00%> (-25.00%) ⬇️
pkg/skaffold/runner/build_deploy.go 56.12% <0.00%> (-12.70%) ⬇️
pkg/skaffold/util/config.go 68.42% <0.00%> (-10.53%) ⬇️
pkg/skaffold/util/port.go 86.66% <0.00%> (-6.78%) ⬇️
cmd/skaffold/app/cmd/run.go 47.05% <0.00%> (-5.89%) ⬇️
pkg/skaffold/build/buildpacks/lifecycle.go 80.00% <0.00%> (-3.75%) ⬇️
... and 50 more

@tejal29 tejal29 added the kokoro:run runs the kokoro jobs on a PR label May 13, 2020
@tejal29 tejal29 self-assigned this May 13, 2020
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label May 13, 2020
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR @ryanhagen!
Can you add a testcase please?

@ryanhagen ryanhagen requested a review from tstromberg as a code owner May 29, 2020 17:49
@tejal29
Copy link
Contributor

tejal29 commented Jun 8, 2020

@ryanhagen the travis job is failing due to lint errors. can you please fix ?

@briandealwis
Copy link
Member

I don't think this PR is necessary as #4294 causes Skaffold to now use helm version --client to avoid contacting the cluster.

@tejal29
Copy link
Contributor

tejal29 commented Jun 11, 2020

@ryanhagen Can we close this PR since #4294 is in as @briandealwis mentioned?

@ryanhagen
Copy link
Author

@tejal29 sounds good to me.

@ryanhagen ryanhagen closed this Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants