-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move global args to be applied to version call #4171
move global args to be applied to version call #4171
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
@googlebot I fixed it. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Codecov Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR @ryanhagen!
Can you add a testcase please?
@ryanhagen the travis job is failing due to lint errors. can you please fix ? |
I don't think this PR is necessary as #4294 causes Skaffold to now use |
@ryanhagen Can we close this PR since #4294 is in as @briandealwis mentioned? |
@tejal29 sounds good to me. |
Description
Executing
helm version
will check the server side namespacekube-system
. In my particular use case of skaffold, I will not have access tokube-system
, therefore, global variable--tiller-namespace
will have to be applied to thehelm version
command, hence this PR.