Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify code to set intents up #4211

Merged
merged 2 commits into from
May 18, 2020
Merged

Simplify code to set intents up #4211

merged 2 commits into from
May 18, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented May 18, 2020

No description provided.

dgageot added 2 commits May 18, 2020 14:11
@dgageot
No error can happen
69332f2 
Signed-off-by: David Gageot <david@gageot.net>
@dgageot
Simplify code
999c696 
Signed-off-by: David Gageot <david@gageot.net>
@codecov
Copy link

codecov bot commented May 18, 2020 •
edited
Loading

Codecov Report

Merging #4211 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
pkg/skaffold/runner/new.go 68.85% <100.00%> (+1.72%) ⬆️
pkg/skaffold/server/server.go 58.57% <0.00%> (ø)

@dgageot
Copy link
Contributor Author

dgageot commented May 18, 2020

ping @nkubala Could you take a look?

@tejal29 tejal29 merged commit df2d2a4 into GoogleContainerTools:master May 18, 2020
@fmotrifork fmotrifork mentioned this pull request May 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tejal29 tejal29 tejal29 approved these changes

@balopat balopat Awaiting requested review from balopat

@briandealwis briandealwis Awaiting requested review from briandealwis

@nkubala nkubala Awaiting requested review from nkubala

Assignees
No one assigned
Labels
cla: yes size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgageot @tejal29 @googlebot