chore: use setValues not values in helm docs example #4334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noticed this when going through the docs recently. I didn't see another PR up for it so thought I'd make the minor contribution here. This change just makes sure the docs are aligned with the current supported helm deployer configuration allowed with skaffold. Can't say this enough, but thank you for this project. Really cool stuff 😎
steve148
requested review from
balopat,
briandealwis,
dgageot,
nkubala,
tejal29 and
tstromberg
as code owners
Codecov Report
@@ Coverage Diff @@
## master #4334 +/- ##
==========================================
+ Coverage 71.77% 71.78% +0.01%
==========================================
Files 324 324
Lines 12482 12499 +17
==========================================
+ Hits 8959 8973 +14
- Misses 2954 2957 +3
Partials 569 569
Continue to review full report at Codecov.
|
tejal29
reviewed
Jun 17, 2020
tejal29
approved these changes
Jun 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Noticed when going through the docs recently that the example listed on the helm deployers page referenced the
valuesfield. If I understand if correctly, the field has been renamed tosetValuesnow. While the example code folders in the repo seem to be aligned with the newer field name, the example given in the helm docs page was not, so I created this incredibly difficult, super arduous fix.I didn't create an issue since I thought it was a fairly small change / edit, but if you'd like I can create an issue first to make sure this is a correct change.
User facing changes (remove if N/A)
Before
After
Follow-up Work (remove if N/A)
Don't think this section applies here.