Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SKAFFOLD_UPDATE_CHECK should also be a global flag #4510

Merged
merged 1 commit into from
Jul 22, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Jul 21, 2020

This specific env var was introduced before we mirrored every command line flag with env vars.
Make sure it's now available either way and properly documented.

Signed-off-by: David Gageot david@gageot.net

@dgageot dgageot requested a review from a team as a code owner July 21, 2020 15:46
@dgageot dgageot requested a review from tstromberg July 21, 2020 15:46
@codecov
Copy link

codecov bot commented Jul 21, 2020

Codecov Report

Merging #4510 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4510      +/-   ##
==========================================
- Coverage   72.35%   72.35%   -0.01%     
==========================================
  Files         333      333              
  Lines       12959    12956       -3     
==========================================
- Hits         9377     9374       -3     
  Misses       2984     2984              
  Partials      598      598              
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/cmd.go 66.42% <100.00%> (+0.24%) ⬆️
pkg/skaffold/update/update.go 53.57% <100.00%> (-5.81%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac11549...b1ff2bc. Read the comment docs.

Signed-off-by: David Gageot <david@gageot.net>
@dgageot
Copy link
Contributor Author

dgageot commented Jul 22, 2020

@briandealwis could you take a look at this one. It doesn't really change anything. Just that it adds the documentation for a env var that we support.

@nkubala nkubala merged commit b9bb604 into GoogleContainerTools:master Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants