Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include k3d 3.0.0 in Skaffold image #4545

Merged
merged 1 commit into from
Jul 23, 2020
Merged

Include k3d 3.0.0 in Skaffold image #4545

merged 1 commit into from
Jul 23, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Jul 23, 2020

Signed-off-by: David Gageot david@gageot.net

@dgageot
Include k3d 3.0.0 in Skaffold image
da1653c 
Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot requested a review from a team as a code owner July 23, 2020 11:02
@dgageot dgageot requested a review from tstromberg July 23, 2020 11:02
@codecov
Copy link

codecov bot commented Jul 23, 2020 •
edited
Loading

Codecov Report

Merging #4545 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4545      +/-   ##
==========================================
+ Coverage   72.56%   72.58%   +0.01%     
==========================================
  Files         334      334              
  Lines       12963    12965       +2     
==========================================
+ Hits         9407     9411       +4     
+ Misses       2960     2959       -1     
+ Partials      596      595       -1
Impacted Files Coverage Δ
...affold/kubernetes/portforward/kubectl_forwarder.go 64.28% <0.00%> (+3.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6551043...da1653c. Read the comment docs.

briandealwis
briandealwis approved these changes Jul 23, 2020
View reviewed changes
Copy link
Member

@briandealwis briandealwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't verify the hash, but in theory it LGTM!

@briandealwis briandealwis merged commit fd77451 into GoogleContainerTools:master Jul 23, 2020
@fmotrifork fmotrifork mentioned this pull request Aug 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandealwis briandealwis briandealwis approved these changes

@tstromberg tstromberg Awaiting requested review from tstromberg

Assignees
No one assigned
Labels
cla: yes size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgageot @briandealwis @googlebot